Build: Add sandbox for react-16 #25199
Conversation
ndelangen
added
ci:daily
| @@ -641,6 +654,7 @@ export const daily: TemplateKey[] = [ | |||
| 'preact-webpack5/default-js', | |||
| 'preact-vite/default-js', | |||
| 'html-vite/default-js', | |||
| 'internal/react16-webpack', | |||
There was a problem hiding this comment.
This should do it right?
I ran yarn get-template --cadence daily --check but it didn't prompt me to change any numbers, which i was expecting.
There was a problem hiding this comment.
It's because the template has inDevelopment: true, it gets completely ignored. you need to remove that flag and then to the dance:
- Changing the sandbox generator to point at this branch
- Trigger the generator
- Change the sandbox generator back again
- Merge this before the daily generator kicks in
There was a problem hiding this comment.
This is what should have happened without the inDevelopment flag:
I added a small note to the generated message which will show the inDev templates, hopefully will make things less confusing!
| @@ -641,6 +654,7 @@ export const daily: TemplateKey[] = [ | |||
| 'preact-webpack5/default-js', | |||
| 'preact-vite/default-js', | |||
| 'html-vite/default-js', | |||
| 'internal/react16-webpack', | |||
There was a problem hiding this comment.
It's because the template has inDevelopment: true, it gets completely ignored. you need to remove that flag and then to the dance:
- Changing the sandbox generator to point at this branch
- Trigger the generator
- Change the sandbox generator back again
- Merge this before the daily generator kicks in
|
I see, I'll see if I can perform that dance today @JReinhold |
yannbf
added
ci:daily
|
Thank you @yannbf |
Telescoped #25196
Works on #25179
What I did
Add a sandbox for testing with react16
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>